Skip to content

feat(postcodes/RS): bulk-import 1,170 Serbia postcodes via Pošta Srbije (#1039)#1466

Merged
dr5hn merged 1 commit into
masterfrom
feat/postcodes-serbia
Apr 27, 2026
Merged

feat(postcodes/RS): bulk-import 1,170 Serbia postcodes via Pošta Srbije (#1039)#1466
dr5hn merged 1 commit into
masterfrom
feat/postcodes-serbia

Conversation

@dr5hn
Copy link
Copy Markdown
Owner

@dr5hn dr5hn commented Apr 27, 2026

Summary

Adds 1,170 Serbia postcodes covering Pošta Srbije's catalogue, sourced
from the MIT-licensed nebjak/serbia-zip-codes-js package.

  • Coverage: country-only by design.
  • Granularity: city level — one record per (5-digit code, city) pair.

Why country-only

Source carries only city + zip_code. Mapping to the 32
okrugs / cities of national importance in states.json would
require an external okrug-by-locality table; matches the
SE/SI/ZA/GR/VN/LV/KE precedent.

Source & licence

Validation

  • python3 -m py_compile clean.
  • 100% of 1,170 codes match country.postal_code_regex (^(\d{5})$).
  • No auto-managed fields (id, created_at, updated_at, flag).

Test plan

  • Importer compiles and runs on a clean checkout.
  • Cross-reference validator passes (regex + country FK).
  • Idempotent merge verified.
  • CI pipeline green.

Refs #1039.

🤖 Generated with Claude Code

…je (#1039)

Source: Pošta Srbije catalogue redistributed via the nebjak/serbia-
zip-codes-js MIT package. Ships country-only — the source carries
city + zip_code only with no okrug (district) mapping (matches the
SE/SI/ZA/GR/VN/LV/KE precedent).

Refs #1039.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 27, 2026 14:19
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement New feature or request labels Apr 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

CSC Validation Report

PR Format

  • ✅ Description provided
  • ✅ Data source linked
  • ✅ Issue linked (recommended for data changes)
  • ✅ Justification / context provided

Labels applied: data:postcodes, large-contribution

⚠️ Large Contribution

This PR contains 1170 records. Large contributions require manual review.

Schema Validation (1170 records)

✅ All records passed validation

Cross-Reference Validation

✅ 1170 reference(s) verified

Source URL Verification

✅ 2 source URL(s) accessible


All checks passed | Status: Ready for review

@dr5hn dr5hn merged commit bc2285c into master Apr 27, 2026
1 check passed
@dr5hn dr5hn deleted the feat/postcodes-serbia branch April 27, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:postcodes enhancement New feature or request large-contribution ready-for-review size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants