feat(postcodes/IS): bulk-import 195 codes via iceaddr (#1039)#1443
Merged
Conversation
Adds Icelandic postcodes via the sveinbjornt/iceaddr Python package which embeds the canonical postcode metadata under MIT licence. 1. bin/scripts/sync/import_iceland_postcodes.py — pipeline that dynamically imports the iceaddr POSTCODES dict and resolves each code's region via prefix range to states.json iso2 1-8 (Statistics Iceland's NUTS-3 boundaries: 1xx-2xx Capital, 3xx Western, 4xx Westfjords, 5xx Northwestern, 6xx Northeastern, 7xx Eastern, 8xx-9xx Southern). 2. contributions/postcodes/IS.json — 195 records with 100% state_id resolution. Locality names combine stadur_nf + lysing (e.g. "Reykjavík, Miðborg"). License & attribution - Source: iceaddr (MIT) embedding Pósturinn data - Each row: source: "iceaddr" Refs: #1039 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dosubot
Bot
added
size:XS
Contributor
CSC Validation ReportPR Format
Labels applied: Schema Validation (195 records)✅ All records passed validation Cross-Reference Validation✅ 390 reference(s) verified ✅ All checks passed | Status: Ready for review |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds Icelandic postcode coverage by introducing a generated IS.json dataset and a companion import script that builds it from the sveinbjornt/iceaddr source.
Changes:
- Add
contributions/postcodes/IS.jsonwith 195 Icelandic postcode records including state mapping and locality names. - Add
bin/scripts/sync/import_iceland_postcodes.pyto import/merge postcodes from aniceaddrpostcodes.pyfile and write the JSON output.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| contributions/postcodes/IS.json | New Iceland postcode dataset (codes, locality names, resolved state IDs/codes, and source attribution). |
| bin/scripts/sync/import_iceland_postcodes.py | New importer script to generate/merge IS.json from the iceaddr upstream data. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Icelandic postcodes via the
sveinbjornt/iceaddrPython package (MIT, embeds Pósturinn data).195 codes, 100% state_id. Region resolution via prefix → Statistics Iceland NUTS-3 boundaries (1xx-2xx Capital, 3xx Western, 4xx Westfjords, 5xx Northwestern, 6xx Northeastern, 7xx Eastern, 8xx-9xx Southern). Locality names combine stadur_nf + lysing.
Refs: #1039