Skip to content

feat(postcodes/GP): add Guadeloupe major-commune postcodes (#1039)#1424

Merged
dr5hn merged 2 commits into
masterfrom
feat/postcodes-guadeloupe
Apr 27, 2026
Merged

feat(postcodes/GP): add Guadeloupe major-commune postcodes (#1039)#1424
dr5hn merged 2 commits into
masterfrom
feat/postcodes-guadeloupe

Conversation

@dr5hn
Copy link
Copy Markdown
Owner

@dr5hn dr5hn commented Apr 27, 2026

Adds 4 well-known Guadeloupe communes covering both arrondissements:

state_code Arrondissement Code Commune
01 Basse-Terre 97100 Basse-Terre (capital)
01 Basse-Terre 97120 Saint-Claude
02 Pointe-à-Pitre 97110 Pointe-à-Pitre
02 Pointe-à-Pitre 97122 Baie-Mahault

GP uses the French postal system with 971## codes (~32 communes total). Shipping 4 high-confidence well-known communes; remaining can land in follow-up PRs.

Refs: #1039

Adds 4 Guadeloupe postcodes covering both arrondissements:

  01 Basse-Terre arr.       -> 97100 Basse-Terre (capital), 97120 Saint-Claude
  02 Pointe-a-Pitre arr.    -> 97110 Pointe-a-Pitre, 97122 Baie-Mahault

GP uses the French postal system with 971## codes (~32 communes total).
Shipping 4 high-confidence well-known communes; remaining can land in
follow-up PRs.

Refs: #1039

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 27, 2026 06:56
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

CSC Validation Report

PR Format

  • ✅ Description provided
  • ❌ Data source linked
  • ✅ Issue linked (recommended for data changes)
  • ✅ Justification / context provided

Labels applied: data:postcodes

Schema Validation (4 records)

✅ All records passed validation

Cross-Reference Validation

✅ 8 reference(s) verified


All checks passed | Status: Ready for review

@dosubot dosubot Bot added the enhancement New feature or request label Apr 27, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds initial Guadeloupe (GP) postcode coverage by introducing a new country-specific postcodes contribution file with a small set of high-confidence commune-level codes.

Changes:

  • Added contributions/postcodes/GP.json with 4 Guadeloupe postcode records.
  • Included country_id/country_code and state_id/state_code metadata per record.

Comment thread contributions/postcodes/GP.json Outdated
Comment on lines +13 to +28
"code": "97120",
"country_id": 88,
"country_code": "GP",
"state_id": 5384,
"state_code": "01",
"locality_name": "Saint-Claude",
"type": "full",
"source": "manual"
},
{
"code": "97110",
"country_id": 88,
"country_code": "GP",
"state_id": 5385,
"state_code": "02",
"locality_name": "Pointe-a-Pitre",
Copy link

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Postcode entries appear to be expected in ascending code order (e.g., contributions/postcodes/GF.json, LI.json). Here 97120 is listed before 97110, which breaks ordering and makes diffs/maintenance harder. Please reorder the objects by code (97100, 97110, 97120, 97122).

Suggested change
"code": "97120",
"country_id": 88,
"country_code": "GP",
"state_id": 5384,
"state_code": "01",
"locality_name": "Saint-Claude",
"type": "full",
"source": "manual"
},
{
"code": "97110",
"country_id": 88,
"country_code": "GP",
"state_id": 5385,
"state_code": "02",
"locality_name": "Pointe-a-Pitre",
"code": "97110",
"country_id": 88,
"country_code": "GP",
"state_id": 5385,
"state_code": "02",
"locality_name": "Pointe-a-Pitre",
"type": "full",
"source": "manual"
},
{
"code": "97120",
"country_id": 88,
"country_code": "GP",
"state_id": 5384,
"state_code": "01",
"locality_name": "Saint-Claude",

Copilot uses AI. Check for mistakes.
Comment thread contributions/postcodes/GP.json Outdated
Comment on lines +36 to +37
"state_id": 5385,
"state_code": "02",
Copy link

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Baie-Mahault is assigned to state_id 5385 / state_code "02" here, but the existing city record in contributions/cities/GP.json assigns Baie-Mahault to state_id 5384 / state_code "01". To keep cross-file consistency for GP, please either align this postcode record’s state fields with the existing city/state mapping, or update the related city/state mapping in the same PR so all references agree.

Suggested change
"state_id": 5385,
"state_code": "02",
"state_id": 5384,
"state_code": "01",

Copilot uses AI. Check for mistakes.
…h cities

Per Copilot review:
1. Sort records by code ascending (97100, 97110, 97120, 97122)
2. Baie-Mahault state_id 5385/'02' → 5384/'01' to match cross-file
   consistency with contributions/cities/GP.json

Note: contributions/cities/GP.json appears to use island-based attribution
(Basse-Terre island vs Grande-Terre island) rather than INSEE arrondissement
boundaries. Several Grande-Terre communes including Baie-Mahault are
attached to state_id=5384 (Basse-Terre arrondissement) in cities. This
PR matches that convention rather than fork it; arrondissement-vs-island
data quality is a separate concern.
@dr5hn dr5hn merged commit 48a639b into master Apr 27, 2026
1 check passed
@dr5hn dr5hn deleted the feat/postcodes-guadeloupe branch April 27, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:postcodes enhancement New feature or request ready-for-review size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants