Skip to content

fix(PH): correct Negros Occidental/Oriental native names#1386

Merged
dr5hn merged 1 commit into
masterfrom
fix/issue-1384-negros-native-names
Apr 25, 2026
Merged

fix(PH): correct Negros Occidental/Oriental native names#1386
dr5hn merged 1 commit into
masterfrom
fix/issue-1384-negros-native-names

Conversation

@dr5hn
Copy link
Copy Markdown
Owner

@dr5hn dr5hn commented Apr 25, 2026

Closes #1384

Fixes the auto-translation errors where native field had Western blacks / Eastern blacks instead of the proper Spanish-origin names.

Changes

  • native for Negros Oriental (id 1350): Eastern blacksNegros Oriental
  • native for Negros Occidental (id 1351): Western blacksNegros Occidental
  • Cleaned racial mistranslations in translations for both records:
    • pt, pt-BR: Negros Orientais/Negros OcidentaisNegros Oriental/Negros Occidental
    • tr: Zenci Doğulu/Batılı ZencilerNegros Oriental/Negros Occidental
    • it (Occidental): Negri OccidentaliNegros Occidental

Rationale

"Negros" is a Spanish-origin toponym (after the indigenous Negritos people). It is a proper noun and is borrowed unchanged into Filipino/Tagalog — confirmed by 83 of 99 PH state records using native = name. Auto-translation incorrectly treated Negros as the Spanish/Italian/Portuguese/Turkish racial adjective.

Locales that simply translate the directional modifier (zh-CN, fa, hr for Occidental, uk for Oriental) while keeping a transliterated Negros/Неґрос/内格罗斯/نگروس were left intact — those are legitimate localizations, not racial mistranslations.

Validation

  • python3 -c "import json; json.load(open('contributions/states/states.json'))" → JSON OK

Copilot AI review requested due to automatic review settings April 25, 2026 11:21
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. typo fix labels Apr 25, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects mistranslated/auto-translated native names and translations for the Philippine provinces Negros Oriental and Negros Occidental in contributions/states/states.json, replacing racially incorrect renderings with the intended proper-noun place names.

Changes:

  • Updated native values for Negros Oriental/Occidental to the proper province names.
  • Cleaned multiple translations entries (e.g., pt, pt-BR, tr, it) to remove racial mistranslations.

Comment on lines +49502 to +49503
"pt-BR": "Negros Occidental",
"pt": "Negros Occidental",
Copy link

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Portuguese translations for this province should likely use Portuguese spelling ("Ocidental") rather than Spanish ("Occidental"). This is also consistent with other PH provinces like "Davao Occidental"/"Misamis Occidental" which use "pt"/"pt-BR": "... Ocidental" in this file.

Copilot uses AI. Check for mistakes.
@dr5hn dr5hn merged commit 3291ae7 into master Apr 25, 2026
5 of 6 checks passed
@dr5hn dr5hn deleted the fix/issue-1384-negros-native-names branch April 25, 2026 11:38
dr5hn added a commit that referenced this pull request Apr 25, 2026
…#1390)

Cleans residual auto-translation errors in the `native` field where Spanish-origin
proper nouns ("Sur", "Norte", "del", "Nueva", "La") and acronyms (CALABARZON,
MIMAROPA) had been mistranslated or stylized. Filipino preserves these Spanish
toponyms unchanged, so `native` is set to match `name` (the convention used by
83 of 99 PH states). Follow-up to #1384 / #1386.

Records corrected:
- 1287 Camarines Sur ("Camarines on")
- 1293 Tawi-Tawi ("Tawi-tawi")
- 1294 Calabarzon ("CALABARZON")
- 1299 Mimaropa ("MIMAROPA")
- 1302 Zamboanga del Norte ("North Zamboanga")
- 1317 La Union ("Union")
- 1318 Davao del Sur ("South Davao")
- 1321 Ilocos Sur ("Ilocos Sur Ilocos Sur")
- 1333 Lanao del Sur ("Lanao of the South")
- 1347 Maguindanao del Sur ("South.")
- 1348 Misamis Oriental ("Eastern Misamis")
- 1357 Zamboanga del Sur ("South Zamboanga")
- 1358 Nueva Vizcaya ("New Biscay")
- 1360 Nueva Ecija ("New Ecija")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:states large-contribution size:XS This PR changes 0-9 lines, ignoring generated files. typo fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Negros Occidental/Oriental have native names as "Western blacks" and "Eastern blacks"

2 participants