Skip to content

Improve zh-CN translations and regional naming consistency for China locales#1382

Merged
dr5hn merged 7 commits into
dr5hn:masterfrom
Yi-pixel:master
Apr 25, 2026
Merged

Improve zh-CN translations and regional naming consistency for China locales#1382
dr5hn merged 7 commits into
dr5hn:masterfrom
Yi-pixel:master

Conversation

@Yi-pixel

Copy link
Copy Markdown
Contributor

Summary

This PR improves the accuracy and consistency of Chinese (zh-CN) translations and naming conventions for regions and cities in China-related locale files.

Changes

  • Refined Chinese translations for multiple provincial regions to ensure more precise and standardized naming.
  • Updated the naming of Ningxia, including its native name and translations.
  • Corrected the zh-CN translation for Guangdong in states.json.
  • Updated the zh-CN translation for Tibet (Xizang) in states.json, aligned with references from the Chinese Ministry of Foreign Affairs.
  • Fixed typos in city names across multiple entries in CN.json.

Notes

  • Translation updates aim to align with authoritative and commonly accepted naming standards.

  • External reference used for Tibet naming:

  • Due to limited familiarity with other languages, translations for non-zh-CN locales have not been reviewed or modified in this PR.

Impact

  • Improves localization quality and linguistic accuracy.
  • Ensures consistency across region and city naming in Chinese.

@Yi-pixel Yi-pixel marked this pull request as ready for review April 19, 2026 12:10
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement New feature or request labels Apr 19, 2026
Yi-pixel and others added 2 commits April 19, 2026 20:21
Per repo convention, `name` is always the English/canonical identifier
and `native` holds the local-script name. This reverts two `name`
field changes that replaced English with Chinese characters:

- Tibet (id 2264): name reverted to "Tibet" (the established English
  exonym). The PR's other improvements remain — `native` is now
  correctly "西藏自治区" and the zh-CN translation includes the proper
  自治区 suffix.
- Hong Kong SAR (id 2267): name reverted to "Hong Kong SAR". The
  contributor most likely intended to update `native` (which was
  English-pinyin "Hong Kong SAR" — wrong for a `native` field), but
  edited `name` instead. Macau in the same PR was correctly handled
  by editing `native`.

All ~30 typo fixes and zh-CN suffix improvements in this PR are
preserved.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

@dr5hn dr5hn left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated. Repo convention: name = canonical English identifier, native = local-script name.

✅ All typo fixes in CN.json prefectures correct (强→羌, 紫枝→自治, 资治→自治, 一族→彝族, 超县组资→朝鲜族 etc.)
✅ All native field updates correct: previously held English-pinyin (e.g., "Beijing", "Macau SAR") which violated the convention; now properly Chinese characters (e.g., "北京市", "澳门特别行政区").
✅ All zh-CN translation updates correct: adding proper PRC administrative suffix (省/市/自治区) and replacing the "粤" abbreviation with "广东省".
✅ Ningxia Huizu → Ningxia Hui in Western-language translations is consistent.

⚠️ Pushed fixup commit f85aaff to revert two name-field changes that violated the convention by replacing English with Chinese characters: Tibet (id 2264) and Hong Kong SAR (id 2267). All other improvements preserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants