Skip to content

Added Oye City#1213

Merged
dr5hn merged 8 commits into
dr5hn:masterfrom
Towbee05:tobi-oye
Oct 18, 2025
Merged

Added Oye City#1213
dr5hn merged 8 commits into
dr5hn:masterfrom
Towbee05:tobi-oye

Conversation

@Towbee05
Copy link
Copy Markdown
Contributor

πŸ“ Description

Found a missing city "Oye" and added it.

🎯 Type of Change

  • πŸ› Bug fix (data correction, fixing incorrect information)
  • ✨ New feature (adding new cities, states, or countries)
  • πŸ“ Data update (updating existing information with more accurate data)
  • πŸ”§ Build/Infrastructure (changes to scripts, workflows, or tooling)
  • πŸ“š Documentation (updates to README, guides, or comments)
  • πŸ—‘οΈ Data removal (removing duplicate or invalid entries)

🌍 Affected Entities

  • Country/Countries: Nigeria
  • State(s)/Province(s): Ekiti
  • City/Cities: Oye

βœ… Checklist

  • I have read the CONTRIBUTING.md guidelines
  • I made changes to JSON files in the contributions/ directory (preferred method)
  • I have run python3 bin/build_from_contributions.py locally and it completed successfully
  • My changes follow the existing data format and structure
  • I have verified the data against reliable sources (WikiData, Wikipedia, official sources)
  • For data corrections: I have provided sources/references below

πŸ“š Sources & References

https://en.wikipedia.org/wiki/Oye,_Ekiti

πŸ§ͺ Testing

  • Built the database locally from contributions
  • Verified no build errors
  • Checked data integrity (correct IDs, relationships, etc.)
  • Tested in my application (if applicable)

πŸ“Έ Screenshots/Evidence (Optional)

πŸ’¬ Additional Notes


Note for Reviewers:

  • βœ… Changes should be in contributions/ directory JSON files
  • βœ… New records should NOT have id field (auto-assigned during build)
  • βœ… Verify sources are reliable and data is accurate

@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. missing-records Missing some records labels Oct 17, 2025
@dr5hn dr5hn requested a review from Copilot October 18, 2025 06:10
@dr5hn dr5hn linked an issue Oct 18, 2025 that may be closed by this pull request
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds new city data under Nigeria/Ekiti to fill a missing locality.

  • Adds Oye-Ekiti (Oye) to contributions/cities/NG.json
  • Also adds Ilawe-Ekiti in the same state
  • Minor formatting inconsistencies present in the new entries

Comment thread contributions/cities/NG.json Outdated
"country_id" : 161,
"country_code" : "NG",
"latitude" : "7.798035744393215",
"longitude" : "5.328547174323522",
Copy link

Copilot AI Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Oye-Ekiti entry is missing the timezone field; other entries (including the newly added Ilawe-Ekiti just above) include timezone. Please add "timezone": "Africa/Lagos" for consistency with the schema and the region.

Suggested change
"longitude" : "5.328547174323522",
"longitude" : "5.328547174323522",
"timezone" : "Africa/Lagos",

Copilot uses AI. Check for mistakes.
Comment thread contributions/cities/NG.json Outdated
Comment on lines +17171 to +17189
"name" : "Ilawe-Ekiti",
"state_id" : 309,
"state_code" : "EK",
"country_id" : 161,
"country_code" : "NG",
"latitude" : "7.594942695084398",
"longitude" : "5.103406817673924",
"timezone" : "Africa/Lagos",
"wikiDataId": "Q3509400"
},
{
"name" : "Oye-Ekiti",
"state_id" : 309,
"state_code" : "EK",
"country_id" : 161,
"country_code" : "NG",
"latitude" : "7.798035744393215",
"longitude" : "5.328547174323522",
"wikiDataId" : "Q7116252"
Copy link

Copilot AI Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Inconsistent JSON spacing around colons within this object (e.g., "name" : vs "wikiDataId":). Please standardize to the prevailing style used in the file (no space before the colon) for all keys in the newly added entries.

Suggested change
"name" : "Ilawe-Ekiti",
"state_id" : 309,
"state_code" : "EK",
"country_id" : 161,
"country_code" : "NG",
"latitude" : "7.594942695084398",
"longitude" : "5.103406817673924",
"timezone" : "Africa/Lagos",
"wikiDataId": "Q3509400"
},
{
"name" : "Oye-Ekiti",
"state_id" : 309,
"state_code" : "EK",
"country_id" : 161,
"country_code" : "NG",
"latitude" : "7.798035744393215",
"longitude" : "5.328547174323522",
"wikiDataId" : "Q7116252"
"name": "Ilawe-Ekiti",
"state_id": 309,
"state_code": "EK",
"country_id": 161,
"country_code": "NG",
"latitude": "7.594942695084398",
"longitude": "5.103406817673924",
"timezone": "Africa/Lagos",
"wikiDataId": "Q3509400"
},
{
"name": "Oye-Ekiti",
"state_id": 309,
"state_code": "EK",
"country_id": 161,
"country_code": "NG",
"latitude": "7.798035744393215",
"longitude": "5.328547174323522",
"wikiDataId": "Q7116252"

Copilot uses AI. Check for mistakes.
Comment thread contributions/cities/NG.json Outdated
"updated_at": "2025-10-13T13:38:21",
"flag": 1,
"wikiDataId": "Q124669880"
},
Copy link

Copilot AI Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] There is trailing whitespace after the comma on this line. Please remove trailing spaces to keep the JSON clean and consistent with the rest of the file.

Suggested change
},
},

Copilot uses AI. Check for mistakes.
@dr5hn dr5hn mentioned this pull request Oct 18, 2025
16 tasks
@Towbee05
Copy link
Copy Markdown
Contributor Author

White space issue resolved already

@dr5hn dr5hn requested a review from Copilot October 18, 2025 10:54
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Oct 18, 2025
@dr5hn dr5hn merged commit 35ecca3 into dr5hn:master Oct 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer missing-records Missing some records size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Data]: City not found

3 participants