Strictly enforce str message type in producer.send_messages #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -42,9 +42,14 @@ kafka = KafkaClient("localhost:9092") | |||
|
|
|||
| # To send messages synchronously | |||
| producer = SimpleProducer(kafka) | |||
|
|
|||
| # Note that messages must be type str | |||
There was a problem hiding this comment.
Perhaps, "Note that the application is responsible for encoding messages to type str" ?
added 2 commits
August 26, 2014 16:59
…tr (or subclass); document
… in send_messages
dpkp
added a commit
that referenced
this pull request
Aug 27, 2014
Strictly enforce str message type in producer.send_messages
|
I remember what was going on. We had a wrapper that looked like this: It's a super awesome abstraction to have which simplified the surrounding code a lot. However, the usage of vargs forces a lack of type safety at this level, because *msg_list simply requires an iterable. Probably not a kafka-python error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise TypeError in kafka.producer.send_messages if any msg is not a str (or subclass)
Improve documentation
Add producer unit test