Add Electron upgrade checks to Electronegativity#60
Merged
Conversation
Contributor
|
Hey @jkleinsc, |
Contributor
Author
|
@phosphore sounds good. |
Contributor
Author
|
@phosphore it took me a while to get back to this, but I've now added tests. |
Contributor
|
Love this! C: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the option to run Electron upgrade checks with Electronegativity. The intention of this feature is for developers to discover the breaking changes that will affect them when they upgrade to a newer version of Electron.
As it currently stands this PR adds checks for Electron versions 5-8.
To use this feature a new argument,
-uor--upgradeis used. When using this argument, the user will need to pass along a string in the format ofx..ywhere x is the user's current version of Electron and y is the user's target version of Electron to upgrade to. For example for an app that is currently using Electron 4 and trying to upgrade to Electron 8, electronegativity would be invoked as follows:electronegativity -i /path/to/electron/app -v -u 4..8