Skip to content

fix: update mocha dependency#100

Merged
phosphore merged 1 commit into
doyensec:masterfrom
MarshallOfSound:master
Dec 5, 2022
Merged

fix: update mocha dependency#100
phosphore merged 1 commit into
doyensec:masterfrom
MarshallOfSound:master

Conversation

@MarshallOfSound

Copy link
Copy Markdown
Contributor

This was throwing up flags in a yarn audit output. This bumps the minimum node version to >=14 which is current LTS anyway

@malept

malept commented Dec 1, 2022

Copy link
Copy Markdown

Somewhat related question: why is mocha a production dependency?

@ikkisoft ikkisoft requested a review from phosphore December 2, 2022 09:46
@phosphore phosphore merged commit d88fe4f into doyensec:master Dec 5, 2022
@phosphore

Copy link
Copy Markdown
Contributor

Somewhat related question: why is mocha a production dependency?

Good question, moved it into devdeps

@malept

malept commented Dec 5, 2022

Copy link
Copy Markdown

Somewhat related question: why is mocha a production dependency?

Good question, moved it into devdeps

Thanks! Looking forward to a new release of @doyensec/electronegativity so Electron Forge can reduce its production dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants