-
Notifications
You must be signed in to change notification settings - Fork 329
[DOC] Adding guides to explain UDF serialization and Broadcast variable usage #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Adding guides to explain UDF serialization and Broadcast variable usage #464
Conversation
@bamurtaugh Could you please take a look at the following guides I wrote to explain the UDF serialization behavior and Broadcast variable usage? Thank you for your time! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are great, thanks so much for working on them @Niharikadutta 😄
@imback82 , @bamurtaugh Have added a section for UDF serialization and addressed all remaining comments. Please feel free to take a look and let me know your thoughts. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @Niharikadutta!
@imback82 Please let me know if this looks ok or if there are any changes/suggestions you have. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few nit comments, but LGTM in general.
@imback82 addressed remaining comments, please let me know if it looks ok. Thanks! |
We are excited to review your PR.
So we can do the best job, please check:
Fixes #nnnn
in your description to cause GitHub to automatically close the issue(s) when your PR is merged.