Disable static graph restore for file-based apps #50245
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR disables static graph restore for file-based apps to resolve issue #49876. The change prevents MSBuild from using static graph evaluation during restore operations for C# files that are run directly without a project file.
- Adds
RestoreUseStaticGraphEvaluation>falseproperty to virtual project files generated for file-based apps - Includes test coverage for both implicit and explicit static graph restore scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Cli/dotnet/Commands/Run/VirtualProjectBuildingCommand.cs | Adds property to disable static graph evaluation in generated virtual project files |
| test/dotnet.Tests/CommandTests/Run/RunFileTests.cs | Adds tests to verify static graph restore behavior and updates existing test project templates |
| @@ -891,6 +891,7 @@ public static void WriteProjectFile( | |||
| writer.WriteLine(""" | |||
| <EnableDefaultCompileItems>false</EnableDefaultCompileItems> | |||
| <DisableDefaultItemsInProjectFolder>true</DisableDefaultItemsInProjectFolder> | |||
| <RestoreUseStaticGraphEvaluation>false</RestoreUseStaticGraphEvaluation> | |||
There was a problem hiding this comment.
Should we try looking through the property directives and seeing if any of them are an explicit enable of static graph, and give a more reasonable error if so? Or is it too niche?
|
/backport to release/10.0.1xx |
|
Started backporting to release/10.0.1xx: https://github.com/dotnet/sdk/actions/runs/17297899577 |
|
@jjonescz backporting to "release/10.0.1xx" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Disable static graph restore for file-based apps
Applying: Improve error
error: sha1 information is lacking or useless (src/Cli/dotnet/Commands/Run/VirtualProjectBuildingCommand.cs).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0002 Improve error
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
Closes #49876.