Skip to content

Add tar.gz as new output option. #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Danielku15
Copy link
Contributor

Resolves #283

ℹ️ At this point this PR is still a draft/proposal for further discussion before finalizing it.

In this proposal some new options would allow the writing of tar.gz files as output. Essential changes:

  • New TarOutputDirectory parameter which would activate the tar.gz writing.
  • New OutputMode which allows more specific control of which output flow to follow (local daemon, remote push, file writing).

Pending change until approval of approach: writing tests.

Alternative proposal: Use the new "local daemon" feature to have something like a fake "tar" Daemon. Unfortunately at this point I am lacking an option to then pass in the folder into which to write the tarballs. And also the output property on the Task would be missing in this case unless we extend it. Would need some confirmation on the desired public API for this feature.

@baronfel
Copy link
Member

baronfel commented Mar 3, 2023

Noting that there's some conflict here with #350 - we'll need to discuss approaches.

@baronfel
Copy link
Member

We'd like to go forward with this approach @Danielku15 - the team likes the explicitness of the OutputMode flag and the overall approach of elevating each output mechanism into a distinct case. We'd love to see tests for this, or we can help out to get this over the finish line.

@Danielku15
Copy link
Contributor Author

@baronfel Things are currently quite busy on my side. I will try to continue on this topic soon but I plan to wrap everything up and extend it with tests.

@baronfel
Copy link
Member

No pressure at all - please let us know if there's anything the team can do to lighten the load :)

@baronfel
Copy link
Member

FYI: We're about to go into code freeze on this repo while we prepare to merge into the SDK repo. As a result we will need to retarget this PR. Happy to help navigate that process if you need it!

@Danielku15
Copy link
Contributor Author

Shouldn't be a problem. I made those kind of changes already 2-3 times on top of different states. One more time should go very smooth 😉

@baronfel
Copy link
Member

Hi Daniel - do you want to pick this up still? If you don't have time that's ok too :)

@Danielku15
Copy link
Contributor Author

@baronfel Sure. Things are getting a bit more relaxed currently and I could take this up. I am just wondering if it makes sense to implement first #379 to have only one single tar.gz output. Currently due to the different metadata generated in the archive we otherwise would have the need for multiple outputs.

What do you think?

@Danielku15
Copy link
Contributor Author

Closing the PR here. We can continue here: dotnet/sdk#32132

The design of the solution changed quite a bit. It made more sense to rework things in a bigger scale to solve multiple problems at once.

@Danielku15 Danielku15 closed this Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Produce an image as .tar.gz
3 participants