Skip to content

Add a comment in source-generated regexes explaining why they cannot have optimized code. #66114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 3, 2022
Merged

Add a comment in source-generated regexes explaining why they cannot have optimized code. #66114

merged 2 commits into from
Mar 3, 2022

Conversation

teo-tsirpanis
Copy link
Contributor

Salvaged from my work on #66047.

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-System.Text.RegularExpressions labels Mar 2, 2022
@ghost
Copy link

ghost commented Mar 2, 2022

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

Salvaged from my work on #66047.

Author: teo-tsirpanis
Assignees: -
Labels:

area-System.Text.RegularExpressions, community-contribution
Milestone: -

@teo-tsirpanis teo-tsirpanis added the source-generator Indicates an issue with a source generator feature label Mar 2, 2022
stephentoub
stephentoub reviewed Mar 2, 2022
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. It was on my todo list :)

@teo-tsirpanis
Copy link
Contributor Author

PR feedback was addressed.

stephentoub
stephentoub approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephentoub stephentoub merged commit 7db092a into dotnet:main Mar 3, 2022
@teo-tsirpanis teo-tsirpanis deleted the regexgen-explain branch March 3, 2022 16:27
@ghost ghost locked as resolved and limited conversation to collaborators Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
area-System.Text.RegularExpressions community-contribution Indicates that the PR has been added by a community member source-generator Indicates an issue with a source generator feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teo-tsirpanis @stephentoub