JIT: Handle async calls implemented via ldvirtftn properly
#118726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handling was missing to mark these as async and to insert async continuations.
github-actions
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
There was a problem hiding this comment.
Pull Request Overview
This PR adds proper async call handling for virtual method calls that are implemented via ldvirtftn in the JIT compiler. The changes ensure that these calls are correctly marked as async and have the necessary async continuation arguments inserted.
Key changes:
- Extracts async call setup logic into reusable helper methods
- Adds async handling for ldvirtftn-based virtual calls
- Includes test infrastructure updates to enable async testing
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/jit/importercalls.cpp | Refactors async call handling into helper methods and adds async support for ldvirtftn calls |
| src/coreclr/jit/compiler.h | Adds declarations for new async call helper methods |
| src/tests/async/Directory.Build.targets | Enables async test builds by uncommenting DisableProjectBuild |
| src/tests/async/async-gvm/async-gvm.csproj | Creates new test project for async generic virtual method testing |
| src/tests/async/async-gvm/async-gvm.cs | Implements test cases for async generic virtual methods |
|
Opened #118735 to fix the failing test (flakey). |
This was referenced Aug 14, 2025
|
All other failures are known, cc @dotnet/jit-contrib @VSadov PTAL @AndyAyersMS |
jakobbotsch
commented
Aug 14, 2025
AndyAyersMS
approved these changes
Aug 14, 2025
VSadov
reviewed
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling was missing to mark these as async and to insert async continuations.
Fix #118714