Fix comments with name of CA2020 rule #118316
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
jkotas
reviewed
Aug 3, 2025
| @@ -473,7 +473,7 @@ public static void WriteIntPtr(IntPtr ptr, int ofs, IntPtr val) | |||
| #if TARGET_64BIT | |||
| WriteInt64(ptr, ofs, (long)val); | |||
| #else // 32 | |||
| #pragma warning disable CA2020 // Prevent from behavioral change | |||
| #pragma warning disable CA2020 // Prevent behavioral change | |||
There was a problem hiding this comment.
Can we get rid of these pragma warning disable instead? E.g. WriteInt32(ptr, ofs, (int)(nint)val);?
There was a problem hiding this comment.
Can we change the method signature to:
public static void WriteIntPtr(IntPtr ptr, int ofs, nint val)There was a problem hiding this comment.
I did this for all Marshal methods where appropriate: #118335
There was a problem hiding this comment.
And Interlocked: #118336
jkotas
added
area-System.Runtime
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/area-system-runtime |
3 tasks
|
Superseded by the two PRs linked above |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.