Skip to content

Fix printing subset help through msbuild #117926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025

Conversation

akoeplinger
Copy link
Member

We need to quote the arguments separately otherwise msbuild just gets a single arg.

Fixes #117920

We need to quote the arguments separately otherwise msbuild just gets a single arg.

Fixes dotnet#117920
@Copilot Copilot AI review requested due to automatic review settings July 22, 2025 11:51
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue with printing subset help through MSBuild by properly quoting command-line arguments. The problem was that MSBuild was receiving a single combined argument instead of separate arguments for the /clp:nosummary and /tl:false parameters.

  • Separates the combined /clp:nosummary /tl:false argument into two distinct quoted arguments
  • Ensures MSBuild correctly parses the command-line parameters when displaying subset help

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 22, 2025
@akoeplinger
Copy link
Member Author

/ba-g this is not tested on public CI and failures are unrelated, merging to stop wasting CI resources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subset Help No Longer Works In Main Build Script
2 participants