-
Notifications
You must be signed in to change notification settings - Fork 5.1k
adding GetOtherNotificationFlags cDAC API #117616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new cDAC API GetOtherNotificationFlags
to read notification flags from the target process, updates the global constants to include DacNotificationFlags
, and registers this global in the native descriptor.
- Implements
IXCLRDataProcess.GetOtherNotificationFlags
with exception handling and debug cross-checks. - Adds
DacNotificationFlags
to managed contract constants. - Registers
DacNotificationFlags
indatadescriptor.h
.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.IXCLRDataProcess.cs | Added new GetOtherNotificationFlags implementation |
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Constants.cs | Added DacNotificationFlags constant |
src/coreclr/debug/runtimeinfo/datadescriptor.h | Registered DacNotificationFlags with CDAC_GLOBAL_POINTER |
Comments suppressed due to low confidence (2)
src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.IXCLRDataProcess.cs:213
- The new
GetOtherNotificationFlags
API lacks unit tests. Consider adding tests to cover successful reads, exception paths, and the debug-mode comparison against the legacy implementation.
int IXCLRDataProcess.GetOtherNotificationFlags(uint* flags)
src/coreclr/debug/runtimeinfo/datadescriptor.h:971
- [nitpick] This line is missing the leading space for alignment with the surrounding
CDAC_GLOBAL_POINTER
entries; adding it will keep the code formatting consistent.
CDAC_GLOBAL_POINTER(DacNotificationFlags, &::g_dacNotificationFlags)
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.IXCLRDataProcess.cs
Outdated
Show resolved
Hide resolved
src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.IXCLRDataProcess.cs
Outdated
Show resolved
Hide resolved
src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.IXCLRDataProcess.cs
Show resolved
Hide resolved
/ba-g infrastructure timeouts |
No description provided.