-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[release/8.0-staging] Remove invalid GCPROTECT
for duplicate slot
#117030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jeffschwMSFT
merged 1 commit into
release/8.0-staging
from
backport/pr-100787-to-release/8.0-staging
Jun 27, 2025
Merged
[release/8.0-staging] Remove invalid GCPROTECT
for duplicate slot
#117030
jeffschwMSFT
merged 1 commit into
release/8.0-staging
from
backport/pr-100787-to-release/8.0-staging
Jun 27, 2025
+0
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging subscribers to this area: @mangod9 |
jeffschwMSFT
approved these changes
Jun 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. please get a code review. we will take for consideration in 8.0.x
This was referenced Aug 5, 2025
Closed
Closed
This was referenced Aug 7, 2025
Closed
Open
Closed
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #100787 to release/8.0-staging
/cc @elinor-fung @AaronRobinsonMSFT @dotnet/interop-contrib
Customer Impact
This is an intermittent issue that can result in a crash when a GC occurs during marshalling of a struct. This was found via tests for 9.0 and reported by an external customer for 8.0.
Regression
dotnet/coreclr#26340
Testing
This issue was hit in GC stress tests. It was fixed in 9.0 and has been working since.
Risk
Low. Fix has been in since 9.0.