Skip to content

[wasm] Consolidate native build logic for WASM #116390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[wasm] Consolidate native build logic for WASM #116390

wants to merge 9 commits into from
+49 −84

Conversation

SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Jun 6, 2025 •
edited
Loading

  1. Make the Windows and not-Windows logic match.
  2. Remove unnecessary arguments.
  3. Simplify.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 6, 2025
@build-analysis build-analysis bot mentioned this pull request Jun 6, 2025
Closed
@SingleAccretion SingleAccretion marked this pull request as ready for review June 7, 2025 11:52
@SingleAccretion SingleAccretion added the arch-wasm WebAssembly architecture label Jun 7, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@lewing lewing requested review from radekdoulik June 16, 2025 14:40
This was referenced Jun 25, 2025
Closed
Closed
Closed
Open
@SingleAccretion SingleAccretion force-pushed the Wasm-Build-Cleanup branch 2 times, most recently from 19991f3 to 02d7aee Compare June 26, 2025 13:03
@build-analysis build-analysis bot mentioned this pull request Jun 26, 2025
Closed
@SingleAccretion SingleAccretion marked this pull request as draft July 11, 2025 10:19
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

This was referenced Aug 14, 2025
Open
Closed
Closed
Closed
@build-analysis build-analysis bot mentioned this pull request Aug 14, 2025
Closed
@SingleAccretion
Pass CMAKE_USE_PTHREADS directly
e122d94 
No need to bounce through shell script parsing.

Also remove unused browser/wasi args from the script.
@SingleAccretion
Delete the unused CMAKE_REPO_ROOT
3fda770
@SingleAccretion
Unix
7aa4b4e
@SingleAccretion
Windows
79ce547
@SingleAccretion
Avoid duplicating cmake args
27b2bcc 
The __ExtraCmakeParams variable is set by some callers of this script.
@SingleAccretion
WIP logging
f0dcded
@SingleAccretion
Revert "WIP logging"
92710fa 
This reverts commit 7555d63.
@SingleAccretion
Remove -DCLR_CMAKE_TARGET_ARCH=wasm
776818a
This was referenced Aug 15, 2025
Open
Closed
@SingleAccretion SingleAccretion marked this pull request as ready for review August 15, 2025 20:14
@SingleAccretion
Copy link
Contributor Author

@dotnet/wasm-eng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radekdoulik radekdoulik Awaiting requested review from radekdoulik

@steveisok steveisok Awaiting requested review from steveisok

@vitek-karas vitek-karas Awaiting requested review from vitek-karas

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-Build-mono community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SingleAccretion