Skip to content

[release/9.0-staging] Fix ordering issue in interface trimming #114509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 10, 2025

Backport of #110098 to release/9.0-staging

ProcessMarkedTypesWithInterfaces can lead to additional interface methods being required, so those need to be marked (done by ProcessInterfaceMethods) even if nothing else happens to put new items in the queue.

/cc @sbomer

Customer Impact

  • Customer reported

Reported in #109850. Upon upgrade to .NET 9, application fails with TypeLoadException.

Regression

  • Yes

Regressed in .NET 9 which had substantial changes to the interface trimming logic.

Testing

Validated it fixes the customer-reported issue locally, and the fix has been in .NET 10 since April. Coming up with a small testcase was nontrivial due to the order dependence - given the scope of the change I believe manual validation is sufficient.

Risk

Low. The fix just ensures that we finish processing interface methods, but doesn't change any of the processing logic.

@github-actions github-actions bot requested a review from marek-safar as a code owner April 10, 2025 22:44
@ghost ghost added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Apr 10, 2025
@dotnet-policy-service dotnet-policy-service bot added the linkable-framework Issues associated with delivering a linker friendly framework label Apr 10, 2025
Copy link
Contributor

Tagging subscribers to this area: @dotnet/illink
See info in area-owners.md if you want to be subscribed.

@carlossanlop
Copy link
Contributor

Friendly reminder that code complete for the may release is next Monday April 14th. If you want this change included in that release, please take it to Tactics and merge the PR before EOD Monday.

@jozkee
Copy link
Member

jozkee commented May 7, 2025

@sbomer friendly reminder that code complete is on Monday May 12th (2:00 PM Pacific) for the June Release. If you'd like to get this change included in that release, please get a Tactics approval and merge this PR before the deadline.

@jozkee
Copy link
Member

jozkee commented Jun 9, 2025

@sbomer reminder that servicing code complete for 9.0.7 is today @ 3PM PST.

@sbomer sbomer closed this Jun 9, 2025
@sbomer sbomer reopened this Jun 9, 2025
@sbomer sbomer requested review from a team and jtschuster June 9, 2025 18:31
@sbomer sbomer added the Servicing-consider Issue for next servicing release review label Jun 9, 2025
@sbomer sbomer added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jun 17, 2025
@sbomer
Copy link
Member

sbomer commented Jun 17, 2025

Marking this approved since it was approved over email.

@tarekgh
Copy link
Member

tarekgh commented Jul 10, 2025

@sbomer are we planning to have this for current release? if so, please ensure merging it soon.

Just reminder Code-complete is 14-Jul 4pm PT cut-off

@agocke
Copy link
Member

agocke commented Jul 11, 2025

/ba-g only failure was infra error ("Agent failed with exception: The machine/process running request 8fe4d16f-53a4-4cf9-ac0c-3bf8809c0675 restarted. Agents can't recover from restarts.")

@agocke agocke merged commit ccf556d into release/9.0-staging Jul 11, 2025
69 of 73 checks passed
@agocke agocke deleted the backport/pr-110098-to-release/9.0-staging branch July 11, 2025 00:57
This was referenced Aug 7, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers linkable-framework Issues associated with delivering a linker friendly framework Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants