Skip to content

Conversation

AaronRobinsonMSFT
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT commented Apr 3, 2025

Fixes #92409

@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 10.0.0 milestone Apr 3, 2025
@Copilot Copilot AI review requested due to automatic review settings April 3, 2025 20:41
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • src/coreclr/dlls/mscorrc/mscorrc.rc: Language not supported
Comments suppressed due to low confidence (2)

src/coreclr/vm/dllimport.cpp:4293

  • Ensure that the additional parameters from GetMethodInfoNoSig (namespaceOrClassName and methodName) are always correctly populated to maintain consistency in the error message formatting.
        {

src/coreclr/dlls/mscorrc/resource.h:38

  • Verify that the new resource identifier does not conflict with existing IDs and that its value aligns with the overall resource numbering scheme.
#define IDS_EE_NDIRECT_NAMED_UNSUPPORTED_SIG    0x1709

@AaronRobinsonMSFT
Copy link
Member Author

Mono doesn't have a consistent error message for this case so I left it "as is".

@AaronRobinsonMSFT AaronRobinsonMSFT changed the title Update error message when the name of the method is known. Create error message when UnmanagedCallersOnly is used with DllImport. Apr 3, 2025
@AaronRobinsonMSFT AaronRobinsonMSFT changed the title Create error message when UnmanagedCallersOnly is used with DllImport. Create error message when UnmanagedCallersOnly is used with DllImport. Apr 3, 2025
@AaronRobinsonMSFT
Copy link
Member Author

/ba-g Timeouts and QUIC

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit cdb3549 into dotnet:main Apr 4, 2025
137 of 147 checks passed
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the runtime_92409 branch April 4, 2025 04:49
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange issues when mixing [UnmanagedCallersOnly] with [DLLImport] - "Method's type signature is not PInvoke compatible" emitted for incorrect methods
4 participants