-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Create error message when UnmanagedCallersOnly
is used with DllImport
.
#114240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AaronRobinsonMSFT
merged 3 commits into
dotnet:main
from
AaronRobinsonMSFT:runtime_92409
Apr 4, 2025
Merged
Create error message when UnmanagedCallersOnly
is used with DllImport
.
#114240
AaronRobinsonMSFT
merged 3 commits into
dotnet:main
from
AaronRobinsonMSFT:runtime_92409
Apr 4, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (1)
- src/coreclr/dlls/mscorrc/mscorrc.rc: Language not supported
Comments suppressed due to low confidence (2)
src/coreclr/vm/dllimport.cpp:4293
- Ensure that the additional parameters from GetMethodInfoNoSig (namespaceOrClassName and methodName) are always correctly populated to maintain consistency in the error message formatting.
{
src/coreclr/dlls/mscorrc/resource.h:38
- Verify that the new resource identifier does not conflict with existing IDs and that its value aligns with the overall resource numbering scheme.
#define IDS_EE_NDIRECT_NAMED_UNSUPPORTED_SIG 0x1709
Mono doesn't have a consistent error message for this case so I left it "as is". |
am11
reviewed
Apr 3, 2025
jkotas
reviewed
Apr 3, 2025
UnmanagedCallersOnly
is used with DllImport
.
jkotas
approved these changes
Apr 3, 2025
jkoritzinsky
approved these changes
Apr 3, 2025
This was referenced Apr 4, 2025
/ba-g Timeouts and QUIC |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92409