-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Make COR_PRF_DISABLE_OPTIMIZATIONS Allowable After Attach and non immutable #113924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make COR_PRF_DISABLE_OPTIMIZATIONS Allowable After Attach and non immutable #113924
Conversation
Tagging subscribers to this area: @tommcdon |
e887b34
to
e4cb08d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far. I like your suggestion to refactor CORDisableJITOptimizations as a Module helper function so I expect that will change it a bit.
Made the suggested changes + tentatively fix test by filtering Inlining requests per module name) |
I could use some help diagnosing what is happening with https://dev.azure.com/dnceng-public/public/_build/results?buildId=1000924&view=logs&jobId=3e93a48f-6568-53f2-76b3-1285c183c39d&j=3e93a48f-6568-53f2-76b3-1285c183c39d&t=313dc435-bc2e-554b-c5b1-106790cdfaec. |
Adding @lewing as this looks like WASM testing |
I think the other failures are unrelated known instabilities |
src/tests/profiler/native/dynamicjitoptimization/dynamicjitoptimization.cpp
Outdated
Show resolved
Hide resolved
Per review comments, did:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your effort! I think it looks good as long as we can confirm the test passes in CI
c73170f
to
954ebc3
Compare
Last round of update:
|
Rebase brought new build failures - but it seems they are their on tip of main branch as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @simonferquel!
Should I worry about the build / test failures ? they all seem unrelated but could use confirmation |
The Build Analysis pipeline should be green before we merge. It uses known issues to filter out failing checks, so the 3 other pipelines that are failing
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
I think the OSX failures are some bad machine configuration. @simonferquel, in addition to Jan's feedback, there are also conflicts in |
…y consistently on that module
…sDisabled() instead
…PRF_DISABLE_INLINING
Co-authored-by: Jan Kotas <[email protected]>
b170069
to
2907634
Compare
I rebased and fixed conflict. I also opened a dummy draft PR (removing an empty line of code) to compare build results (so that I do not introduce regression by feeling a flakky test issue) |
Build analysis is green, thanks for the help working on that one :) |
Implement the changes discussed in #113921, making COR_PRF_DISABLE_OPTIMIZATIONS and COR_PRF_DISABLE_INLINING dynamically flippable, and applied consistently per module.