Fix suboptimal IL for small is patterns - #84961
Open
jjonescz wants to merge 4 commits into
Open
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Optimizes C# lowering for small disjunctive is patterns to avoid temporary booleans and inefficient branches.
Changes:
- Uses inverted linear lowering for binding-free patterns with up to four tests.
- Updates affected IL baselines.
- Adds regression, threshold, binding, and async tests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
LocalRewriter_IsPatternOperator.cs |
Adds the optimized lowering path. |
PatternTests.cs |
Adds regression and boundary tests. |
CodeGenAsyncTests.cs |
Covers async lowering scenarios. |
PatternMatchingTests.cs |
Updates Span pattern IL baselines. |
PatternMatchingTests5.cs |
Updates numeric, string, and Span IL baselines. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #80052.
This PR is a refined version of #82429 (which got stale).
Benchmark: https://gist.github.com/jjonescz/4c35cef07ad198a8da9b17d480da5a99. It also tests sparse vs dense values (so it could be more efficient to consider that too when deciding the lowering strategy), but for starters I think we can simply choose between linear vs DAG lowering on a simple threshold for the number of tests.
See also dotnet/runtime#132452 and dotnet/runtime#132504.
Microsoft Reviewers: Open in CodeFlow