Skip to content

Fix operator override completion #78327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

Fix operator override completion #78327

merged 1 commit into from
Apr 25, 2025

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #78284

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner April 25, 2025 20:53
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 25, 2025
ToddGrun
ToddGrun reviewed Apr 25, 2025
View reviewed changes
src/EditorFeatures/Test2/IntelliSense/CSharpCompletionCommandHandlerTests.vb
"operator -=(int i)")
state.SendTypeChars("operator")
state.SendTab()
Assert.Contains("public override void operator ++()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assert.Contains("public override void operator ++()

Would it be worth asserting that a non-virtual operator doesn't show up?

ToddGrun
ToddGrun approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit 07135c5 into dotnet:features/UserDefinedCompoundAssignment Apr 25, 2025
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the operatorOverrideCompletion branch April 25, 2025 22:25
This was referenced May 6, 2025
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request May 31, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibarbet dibarbet dibarbet approved these changes

@ToddGrun ToddGrun ToddGrun approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CyrusNajmabadi @dibarbet @ToddGrun