Update ApplyUpdates API to account for no-effect changes #78220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Interactive
untriaged
|
@DustinCampbell ptal |
DustinCampbell
approved these changes
Apr 25, 2025
src/Features/Core/Portable/EditAndContinue/EditAndContinueDiagnosticDescriptors.cs
Outdated
Show resolved
Hide resolved
src/Features/Core/Portable/ExternalAccess/Watch/Api/WatchHotReloadService.cs
Outdated
Show resolved
Hide resolved
src/Features/Test/EditAndContinue/EditAndContinueWorkspaceServiceTests.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements support for auto-restarting of projects with rude edits or changes that have no effect.
"No effect" change is a change in top-level code or static constructor that is unlikely to be executed again until the app is restarted.
For each running project the host (dotnet-watch/VS/VS Code) determines whether or not a rude edit that affects this project (the edit is directly in the project itself or in any of its dependencies) should trigger automatic restart of the project. For example, dotnet-watch will enable this restart for all projects if
--no-interactiveis specified. Otherwise, a project can setHotReloadAutoRestartbuild property to opt-into auto-restart.A new overload of
GetUpdatesAsyncis added that can be used to pass this information from the host to Roslyn.If no-effect change is encountered in a project or its dependencies and any running projects that support auto-restart will be restarted. A warning will be reported for projects that do not support auto-restart.
After Roslyn calculates deltas it also produces a set of projects to restart and a set of projects to rebuild.
For each project to restart Roslyn now also calculates the set of projects that caused the restart (e.g. had a rude edit). This can be used by the host to determine whether or not to report rude edits as errors. For example, dotnet-watch will print out rude edits in verbose mode if rude edits are reported for a project that has auto-restart enabled. It will only present rude edits as errors if it prompts the user to confirm restart (not in auto-restart mode).
Related: #78009
Follow ups: