-
Notifications
You must be signed in to change notification settings - Fork 402
Treat warnings as errors in release builds #9719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Lately we've started seeing warnings creeping into the codebase. These should be caught by CI and prevented. To make it easier to reproduce CI behaviour locally, this setting is enabled for release builds. If CI fails and you want to recreate the error locally, switch to release mode and build.
I expect the build of this first commit to fail due to the warnings. Will push up a fix for those warnings next. |
The XAML code generator produces code that uses `XamlServices`, which is obsolete. Unfortunately there doesn't seem to be a way to suppress these warnings without modifying the code generator. Therefore, we allow just this one warning to be not treated as an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Build failed as more warnings snuck in :) |
@LittleLittleCloud I think one of the recently added tests is flakey. I've seen it fail intermittently recently.
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I think I see why it could be flakey. Pushing up a fix. |
|
Lately we've started seeing warnings creeping into the codebase. These should be caught by CI and prevented.
To make it easier to reproduce CI behaviour locally, this setting is enabled for release builds. If CI fails and you want to recreate the error locally, switch to release mode and build.
Microsoft Reviewers: Open in CodeFlow