Build NuGet packages for Orleans 2.0 (.NET Standard) #2362
Conversation
(Original unchanged files from main tree to preserve history)
|
For the scripts themselves, it's easier to review individual commits to see what changedm since the first commit just copied a bunch of files with no changes from the main tree into vNext, so you can ignore reviewing it. The other commits are the interesting ones. |
| <?xml version="1.0"?> | ||
| <package xmlns="http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd"> | ||
| <metadata> | ||
| <id>Microsoft.Orleans.Core</id> |
There was a problem hiding this comment.
I thought we were leaning towards calling this one "Abstractions"
There was a problem hiding this comment.
That name change refactoring was not done yet. Currently these packages are similar in shape with the ones in 1.X
The refactoring will come much later
| <licenseUrl>https://github.com/dotnet/Orleans#license</licenseUrl> | ||
| <iconUrl>https://raw.githubusercontent.com/dotnet/orleans/gh-pages/assets/logo_128.png</iconUrl> | ||
| <summary> | ||
| Core library of Microsoft Orleans - Orleans.dll |
There was a problem hiding this comment.
I think we should use a namespaced dll name and not include it in the package description
There was a problem hiding this comment.
Agreed. Nevertheless those changes are not part of this PR, that's why I was mentioning you should skip reviewing the first commit, as it is a plain copy of what's out there already.
| --> | ||
| <file src="Orleans.SDK.targets" target="build\Microsoft.Orleans.OrleansCodeGenerator.Build.targets" /> | ||
|
|
||
| <file src="ClientGenerator.exe" target="tools" /> |
There was a problem hiding this comment.
Shouldn't these be included via dependencies on other packages?
There was a problem hiding this comment.
Not sure if it's possible, since this is really a tool package. Nevertheless, I only copied how we were doing it before, and I believe after the .NET Core tooling settles and starts using MSBuild again, we should improve this story
|
Yay! Lets test Nugets! :) 🔥 |
|
I'm doing that here: https://github.com/jdom/OrleansHelloWorldSample.Core |
|
YEAH! Got a HelloWorld sample to work ENTIRELY in .NET Core. I had to hardcode a few values in our AppDomain shim, but I'll clean in up on Monday and submit a PR |
|
Great work! 💃 |
|
Still getting up to speed here, but that's fantastic (and very useful to me) news @jdom. Bravo! |
jdom
force-pushed
the
netstandard-nuget
branch
from
6b4040e to
78ea43f
Compare
This builds the packages for the vNext solution