[CryptoTokenKit] Update bindings all the way to Xcode 26.4#25025
Open
[CryptoTokenKit] Update bindings all the way to Xcode 26.4#25025
Conversation
Collaborator
✅ [CI Build #b92a0f4] Build passed (Build packages) ✅Pipeline on Agent |
Collaborator
✅ [PR Build #b92a0f4] Build passed (Detect API changes) ✅Pipeline on Agent |
Collaborator
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
Collaborator
✅ [CI Build #b92a0f4] Build passed (Build macOS tests) ✅Pipeline on Agent |
rolfbjarne
requested changes
Mar 26, 2026
| <returns> | ||
| <para class="improve-task-t-return-type-description">A task that represents the asynchronous CreateNfcSlot operation. The value of the TResult parameter is of type System.Action<CryptoTokenKit.TKSmartCardSlotNFCSession,Foundation.NSError>.</para> | ||
| </returns> | ||
| <remarks>To be added.</remarks> |
Member
There was a problem hiding this comment.
Copilot should never add 'To be added.'
| [iOS (26, 0), Mac (26, 0), TV (26, 0), MacCatalyst (26, 0)] | ||
| [Export ("getSmartCardWithError:")] | ||
| [return: NullAllowed] | ||
| TKSmartCard GetSmartCard (out NSError error); |
Member
There was a problem hiding this comment.
Suggested change
| TKSmartCard GetSmartCard (out NSError error); | |
| TKSmartCard GetSmartCard ([NullAllowed] out NSError error); |
| string SlotName { get; } | ||
|
|
||
| [Export ("updateWithMessage:error:")] | ||
| bool Update (string message, out NSError error); |
Member
There was a problem hiding this comment.
Suggested change
| bool Update (string message, out NSError error); | |
| bool Update (string message, [NullAllowed] out NSError error); |
| string [] RegisteredSmartCardTokens { get; } | ||
|
|
||
| [Export ("registerSmartCardWithTokenID:promptMessage:error:")] | ||
| bool RegisterSmartCard (string tokenId, string promptMessage, out NSError error); |
Member
There was a problem hiding this comment.
Suggested change
| bool RegisterSmartCard (string tokenId, string promptMessage, out NSError error); | |
| bool RegisterSmartCard (string tokenId, string promptMessage, [NullAllowed] out NSError error); |
| bool RegisterSmartCard (string tokenId, string promptMessage, out NSError error); | ||
|
|
||
| [Export ("unregisterSmartCardWithTokenID:error:")] | ||
| bool UnregisterSmartCard (string tokenId, out NSError error); |
Member
There was a problem hiding this comment.
Suggested change
| bool UnregisterSmartCard (string tokenId, out NSError error); | |
| bool UnregisterSmartCard (string tokenId, [NullAllowed] out NSError error); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.