[tools] IOSurface is now working in the simulator.#25022
Conversation
Not sure when it started working, so choosing a conservative OS version.
There was a problem hiding this comment.
Pull request overview
Updates the toolchain’s framework availability metadata so IOSurface is considered usable when building for the iOS/tvOS simulator starting at a specified SDK version.
Changes:
- Mark
IOSurfaceas available in the iOS simulator starting in SDK version 26.0. - Mark
IOSurfaceas available in the tvOS simulator starting in SDK version 26.0.
| { "DeviceCheck", "DeviceCheck", new Version (11, 0), new Version (13, 0) }, | ||
| { "IdentityLookup", "IdentityLookup", 11 }, | ||
| { "IOSurface", "IOSurface", new Version (11, 0), NotAvailableInSimulator /* Not available in the simulator (the header is there, but broken) */ }, | ||
| { "IOSurface", "IOSurface", new Version (11, 0), new Version (26, 0) /* The headers were broken at some point, not sure when they started working again */ }, |
There was a problem hiding this comment.
Changing IOSurface's simulator availability from NotAvailableInSimulator to version 26.0 will change mtouch's behavior: it will no longer emit warning MT5223 for simulator builds when using an SDK >= 26.0. There is an existing test (tests/mtouch/MTouch.cs MT5223) that currently asserts this warning for IOSurface; it should be updated (e.g., conditionalize on SDK/Xcode version or assert that the warning is absent for newer SDKs).
| { "IOSurface", "IOSurface", new Version (11, 0), new Version (26, 0) /* The headers were broken at some point, not sure when they started working again */ }, | |
| { "IOSurface", "IOSurface", new Version (11, 0) /* The headers were broken at some point, not sure when they started working again */ }, |
✅ [CI Build #4fbc06c] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #4fbc06c] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #4fbc06c] Build passed (Build macOS tests) ✅Pipeline on Agent |
🚀 [CI Build #4fbc06c] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 156 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
Not sure when it started working, so choosing a conservative OS version.