[skills] Update macios-binding-creator skill by dalexsoto · Pull Request #24962 · dotnet/macios

dalexsoto · 2026-03-21T04:06:50Z

No description provided.

Training session driven by session fbb72a46 (CarPlay binding) evidence and 3-model evaluation (Sonnet 4.5, GPT-5.1-Codex, GPT-4.1). Changes: - Add 'Struct Array Parameter Binding' section to binding-patterns.md covering [Internal]+IntPtr, factory pattern with fixed, property getters, and InitializeHandle variant (addresses #1 gap from all 3 eval models) - Add named delegate type anti-pattern (NEVER use Action<T> for completion handlers) - Add #nullable enable rule to SKILL.md - Add empty .todo file cleanup guidance to xtro test section - Add struct array recognition trigger with cross-reference Eval results (Sonnet 4.5 before→after): Accuracy: 3/5 → 4/5 Completeness: 2/5 → 3/5 Clarity: 4/5 → 4/5 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

.agents/skills/macios-binding-creator/references/binding-patterns.md

rolfbjarne · 2026-03-23T08:41:43Z

.agents/skills/macios-binding-creator/references/binding-patterns.md

 bool Validate (ValidationHandler handler);
 ```

+> ❌ **NEVER** use `Action<T>` or `Func<T>` for completion handler parameters. Always define a **named delegate type** (e.g., `delegate void MyHandler (...)`) — this produces better API documentation and IntelliSense.


Might be easier to just change sharpie to spit out named delegates instead of Action/Func delegates.

- Use 'Create' instead of 'From' for factory methods (not a verb) - Add note that manual code needs XML documentation comments - Remove redundant empty-array checks (fixed handles zero-length correctly) - Pass selector string to InitializeHandle - Check for null pointer instead of count==0 in property getter - Note that xtro-sharpie may generate Action/Func delegates to convert Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

GetCheckedHandle() throws ObjectDisposedException if the object has been disposed, preventing hard-to-debug native crashes. Added as a general rule in Common Pitfalls and fixed the P/Invoke example. Ref: #24960 (comment) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

vs-mobiletools-engineering-service2 · 2026-03-23T13:07:14Z

✅ [PR Build #8a6c5b8] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 8a6c5b87d4c06fb0a65f564e9fbaea26b7f2c9d9 [PR build]

vs-mobiletools-engineering-service2 · 2026-03-23T13:22:19Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 8a6c5b87d4c06fb0a65f564e9fbaea26b7f2c9d9 [PR build]

vs-mobiletools-engineering-service2 · 2026-03-23T14:01:04Z

✅ [CI Build #8a6c5b8] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 8a6c5b87d4c06fb0a65f564e9fbaea26b7f2c9d9 [PR build]

vs-mobiletools-engineering-service2 · 2026-03-23T14:55:56Z

✅ [CI Build #8a6c5b8] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 8a6c5b87d4c06fb0a65f564e9fbaea26b7f2c9d9 [PR build]

vs-mobiletools-engineering-service2 · 2026-03-23T15:30:25Z

🔥 [CI Build #8a6c5b8] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 1 tests failed, 155 tests passed.

Failures

❌ linker tests

1 tests failed, 43 tests passed.

Failed tests

trimmode link/iOS - simulator/Debug: LaunchFailure

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 8a6c5b87d4c06fb0a65f564e9fbaea26b7f2c9d9 [PR build]

dalexsoto · 2026-03-23T16:05:22Z

unrelated test failure

dalexsoto and others added 2 commits March 20, 2026 23:30

[skills] Update macios-binding-creator skill

e38b257

dalexsoto requested a review from rolfbjarne March 21, 2026 04:06

dalexsoto added the copilot label Mar 21, 2026

This comment has been minimized.

Sign in to view

rolfbjarne requested changes Mar 23, 2026

View reviewed changes

rolfbjarne reviewed Mar 23, 2026

View reviewed changes

dalexsoto requested a review from rolfbjarne March 23, 2026 12:31

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Mar 23, 2026

View reviewed changes

dalexsoto merged commit 0eb08a7 into main Mar 23, 2026
42 of 44 checks passed

Conversation

dalexsoto commented Mar 21, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rolfbjarne Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 23, 2026

✅ [PR Build #8a6c5b8] Build passed (Detect API changes) ✅

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 23, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 23, 2026

✅ [CI Build #8a6c5b8] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 23, 2026

✅ [CI Build #8a6c5b8] Build passed (Build macOS tests) ✅

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 23, 2026

🔥 [CI Build #8a6c5b8] Test results 🔥

Test results

Failures

❌ linker tests

Failed tests

Successes

macOS tests

Uh oh!

dalexsoto commented Mar 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants