-
Notifications
You must be signed in to change notification settings - Fork 825
Refactor Resource Monitoring #6554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
evgenyfedorov2
merged 10 commits into
dotnet:main
from
evgenyfedorov2:users/evgenyfedorov2/refactor_linux_cgroup_options
Jul 3, 2025
Merged
Refactor Resource Monitoring #6554
evgenyfedorov2
merged 10 commits into
dotnet:main
from
evgenyfedorov2:users/evgenyfedorov2/refactor_linux_cgroup_options
Jul 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
07b5619
to
54a0b83
Compare
54a0b83
to
4e16fae
Compare
@nivebb8 do you want to review this? We are removing debug logs, metrics, and adjusting code to use only one boolean flag instead of two. |
amadeuszl
reviewed
Jul 1, 2025
...raries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/LinuxUtilizationProvider.cs
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/ResourceMonitoringOptions.cs
Outdated
Show resolved
Hide resolved
...raries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/LinuxUtilizationProvider.cs
Show resolved
Hide resolved
.../Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring.Tests/Linux/AcceptanceTest.cs
Show resolved
Hide resolved
...raries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/LinuxUtilizationProvider.cs
Show resolved
Hide resolved
nivebb8
reviewed
Jul 2, 2025
src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/ResourceMonitoringOptions.cs
Show resolved
Hide resolved
amadeuszl
approved these changes
Jul 2, 2025
…ptions # Conflicts: # src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/CompatibilitySuppressions.xml
This reverts commit 6a57a63.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CalculateCpuUsageWithoutHostDelta
toUseLinuxCpuUsageV2
.UseDeltaNrPeriodsForCpuCalculation
option and merge its logic withUseLinuxCpuUsageV2
.Microsoft Reviewers: Open in CodeFlow