Accessibility fixes for the HTML report #6329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Libraries/Microsoft.Extensions.AI.Evaluation.Reporting/TypeScript/components/App.css
Show resolved
Hide resolved
...s/Microsoft.Extensions.AI.Evaluation.Reporting/TypeScript/components/ConversationDetails.tsx
Outdated
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.AI.Evaluation.Reporting/TypeScript/components/MetricCard.tsx
Show resolved
Hide resolved
shyamnamboodiripad
approved these changes
Apr 25, 2025
I haven't tried out the changes in the browser, but everything looks reasonable. Thank you for fixing!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of accessibility fixes found using Accessibility Insights for Web plugin. Mostly it amounts to usage of the report via keyboard, and having the right aria-* tags on things.
Also, a few minor bug fixes and adjustments found along the way.
Closes #6215
Microsoft Reviewers: Open in CodeFlow