Skip to content

Add Microsoft.Extensions.AI.Templates third party notices #5949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

MackinnonBuck
Copy link
Member

@MackinnonBuck MackinnonBuck commented Feb 20, 2025

Adds a THIRD-PARTY-NOTICES.TXT file to the Microsoft.Extensions.AI.Templates NuGet package.

In addition to the JS dependencies directly included in the template, I've added notices for 3rd party .NET packages used by the template, even though the template doesn't directly include content from those packages. We can remove those if we don't think it's necessary to include them.

Fixes https://github.com/dotnet/ai-private-planning/issues/259

Microsoft Reviewers: Open in CodeFlow

@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.AI Line 89 88.54 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Caching.Hybrid 82 87
Microsoft.Extensions.AI.Abstractions 82 83
Microsoft.Gen.MetadataExtractor 57 70

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=958459&view=codecoverage-tab

Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

I don't know for sure whether we need to include copies of licenses for things we only consume via NuGet package references and don't redistribute ourselves. @jeffhandley do you know?

@jeffhandley
Copy link
Member

I don't know for sure whether we need to include copies of licenses for things we only consume via NuGet package references and don't redistribute ourselves. @jeffhandley do you know?

I don't think so, since we're not distributing it. I'll double-check though.

@richlander
Copy link
Member

It depends on the vantage point. It's hard to tell since this has something to do with templates.

In the normal case, we don't add 3PN entries for components we don't ship.

For templates, it would be useful to the user to have a 3PN file that reflects their app. That would include the packages.

@jeffhandley jeffhandley merged commit 8fc8a50 into main Feb 27, 2025
6 checks passed
@jeffhandley jeffhandley deleted the mbuck/add-template-third-party-notices branch February 27, 2025 01:03
@jeffhandley jeffhandley added the area-ai-templates Microsoft.Extensions.AI.Templates label Mar 7, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-ai-templates Microsoft.Extensions.AI.Templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants