Skip to content

Use structured output for RTC evaluator #5945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

shyamnamboodiripad
Copy link
Contributor

@shyamnamboodiripad shyamnamboodiripad commented Feb 19, 2025

Also change the base types so that derived types have more control over whether or not structured output should be used.

Also adds some tests to ensure that the RTC works well both when the returned JSON contains reasoning elements as well as if it does not.

Addresses #5888

Microsoft Reviewers: Open in CodeFlow

@shyamnamboodiripad shyamnamboodiripad added the area-ai-eval Microsoft.Extensions.AI.Evaluation and related label Feb 19, 2025
@shyamnamboodiripad shyamnamboodiripad requested a review from a team as a code owner February 19, 2025 22:42
@shyamnamboodiripad
Copy link
Contributor Author

FYI @andhesky

@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.AI.Evaluation.Quality Line 7 4.62 🔻
Microsoft.Extensions.AI Line 89 88.84 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI.Abstractions 82 83
Microsoft.Gen.MetadataExtractor 57 70

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=957094&view=codecoverage-tab

@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.AI Line 89 88.8 🔻
Microsoft.Extensions.AI.Evaluation.Quality Line 7 4.62 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI.Abstractions 82 83
Microsoft.Gen.MetadataExtractor 57 70

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=957269&view=codecoverage-tab

Copy link
Member

@peterwald peterwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Also change the base types so that derived types have more control over whether or not structured output should be used.

Also adds some tests to ensure that the RTC works well both when the returned JSON contains reasoning elements as well as if it does not.

Addresses dotnet#5888
@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.AI Line 89 88.6 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI.Abstractions 82 83
Microsoft.Gen.MetadataExtractor 57 70
Microsoft.Extensions.AI.Evaluation.Quality 0 4

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=958181&view=codecoverage-tab

@shyamnamboodiripad shyamnamboodiripad merged commit 4d3cc4b into dotnet:main Feb 20, 2025
6 checks passed
@shyamnamboodiripad shyamnamboodiripad deleted the structured branch February 20, 2025 20:53
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-ai-eval Microsoft.Extensions.AI.Evaluation and related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants