Skip to content

Use UseZeroToOneRangeForMetrics in Health Checks#5849

Merged
evgenyfedorov2 merged 2 commits intodotnet:mainfrom
evgenyfedorov2:users/evgenyfedorov2/fix_healthcheck_multiplier
Feb 12, 2025
Merged

Use UseZeroToOneRangeForMetrics in Health Checks#5849
evgenyfedorov2 merged 2 commits intodotnet:mainfrom
evgenyfedorov2:users/evgenyfedorov2/fix_healthcheck_multiplier

Conversation

@evgenyfedorov2
Copy link
Copy Markdown
Member

@evgenyfedorov2 evgenyfedorov2 commented Feb 6, 2025

Use UseZeroToOneRangeForMetrics property in Microsoft.Extensions.Diagnostics.HealthChecks.ResourceUtilization package to determine the cpu and metric values range [0;1] vs. [0;100] instead of relying purely on operating system which became inaccurate after the bug fix #5472.

Microsoft Reviewers: Open in CodeFlow

@evgenyfedorov2 evgenyfedorov2 self-assigned this Feb 6, 2025
@evgenyfedorov2 evgenyfedorov2 requested a review from a team as a code owner February 6, 2025 07:16
@evgenyfedorov2 evgenyfedorov2 force-pushed the users/evgenyfedorov2/fix_healthcheck_multiplier branch from 3ead530 to 5071336 Compare February 6, 2025 07:57
@dotnet-comment-bot
Copy link
Copy Markdown
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.Caching.Hybrid Line 86 82.77 🔻
Microsoft.Gen.MetadataExtractor Line 98 57.35 🔻
Microsoft.Gen.MetadataExtractor Branch 98 62.5 🔻
Microsoft.Extensions.AI.Ollama Line 80 78.25 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI.OpenAI 77 78
Microsoft.Extensions.AI.Abstractions 83 84
Microsoft.Extensions.AI 88 89

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=942378&view=codecoverage-tab

@dotnet-comment-bot
Copy link
Copy Markdown
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.Caching.Hybrid Line 86 82.77 🔻
Microsoft.Extensions.AI.Ollama Line 80 78.25 🔻
Microsoft.Gen.MetadataExtractor Line 98 57.35 🔻
Microsoft.Gen.MetadataExtractor Branch 98 62.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI 88 89
Microsoft.Extensions.AI.Abstractions 83 84
Microsoft.Extensions.AI.OpenAI 77 78

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=942514&view=codecoverage-tab

Copy link
Copy Markdown
Contributor

@amadeuszl amadeuszl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resource Monitoring metrics for Windows report utilization in the [0,100] range

3 participants