-
Notifications
You must be signed in to change notification settings - Fork 824
Description
Description
.AddServiceLogEnricher() method with its overloads
Line 22 in 233aa3a
| public static IServiceCollection AddServiceLogEnricher(this IServiceCollection services) |
Line 37 in 233aa3a
| public static IServiceCollection AddServiceLogEnricher(this IServiceCollection services, Action<ApplicationLogEnricherOptions> configure) |
Line 54 in 233aa3a
| public static IServiceCollection AddServiceLogEnricher(this IServiceCollection services, IConfigurationSection section) |
have incorrect names: it should be .AddApplicationLogEnricher(), because the underlying class has this name
extensions/src/Libraries/Microsoft.Extensions.Telemetry/Enrichment/ApplicationLogEnricher.cs
Line 12 in 233aa3a
| internal sealed class ApplicationLogEnricher : IStaticLogEnricher |
Line 14 in 233aa3a
| public static class ApplicationEnricherServiceCollectionExtensions |
This seems to be an oversight during some renaming from Service* to Application*.
Reproduction Steps
n/a
Expected behavior
Extension methods have names .AddApplicationLogEnricher()
Actual behavior
Extension methods have names .AddServiceLogEnricher()
Regression?
No
Known Workarounds
n/a
Configuration
No response
Other information
Just rename the methods, probably in a non-breaking fashion - introduce new methods, deprecate old ones