-
Notifications
You must be signed in to change notification settings - Fork 120
Add command sets to profiler communication channel #6316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
schmittjoseph
merged 21 commits into
dotnet:main
from
schmittjoseph:multiple-message-endpoints
Mar 28, 2024
Merged
Add command sets to profiler communication channel #6316
schmittjoseph
merged 21 commits into
dotnet:main
from
schmittjoseph:multiple-message-endpoints
Mar 28, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jander-msft
reviewed
Mar 27, 2024
jander-msft
reviewed
Mar 27, 2024
src/Profilers/MonitorProfiler/Communication/ManagedMessageCallbackManager.h
Outdated
Show resolved
Hide resolved
jander-msft
reviewed
Mar 27, 2024
jander-msft
reviewed
Mar 27, 2024
jander-msft
reviewed
Mar 27, 2024
wiktork
approved these changes
Mar 28, 2024
jander-msft
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades the profiler channel's messages to now contain a
command set
field to help distinguish between different receivers of the IPC message. There are currently 3 distinct command sets:ServerResponse
,Profiler
, andStartupHook
(currently used by the HostingStartup, but this will become StartupHook-only in the future with the parameter capturing upgrades).This change also allows multiple instances of
MonitorMessageDispatcher
to exist, where each is subscribed to a different command set, though this isn't done in this PR.New IPC message format:
%Payload size%
Other changes in this PR:
Command
to beunsigned
.Release Notes Entry