Skip to content

Make Asp, AspBuild, and ReleaseDate optional in ReleaseConfig #6933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lbussell merged 2 commits into from
Jan 15, 2026
Merged

Make Asp, AspBuild, and ReleaseDate optional in ReleaseConfig #6933

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4b4c5c
Make Asp, AspBuild, and ReleaseDate optional in ReleaseConfig
lbussell Jan 15, 2026
a043dc3
Add MemberNotNullWhen attributes
lbussell Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions eng/update-dependencies/Model/Release/ReleaseConfig.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.Text.Json;
using System.Text.Json.Serialization;

Expand All @@ -26,21 +25,21 @@ internal record ReleaseConfig

public required string Runtime { get; init; }

public required string Asp { get; init; }
public string? Asp { get; init; }

public required List<string> Sdks { get; init; }

[JsonPropertyName("Runtime_Build")]
public required string RuntimeBuild { get; init; }

[JsonPropertyName("Asp_Build")]
public required string AspBuild { get; init; }
public string? AspBuild { get; init; }

[JsonPropertyName("Sdk_Builds")]
public required List<string> SdkBuilds { get; init; }

[JsonPropertyName("Release_Date")]
public required string ReleaseDate { get; init; }
public string? ReleaseDate { get; init; }

public required bool Security { get; init; }

Expand All @@ -49,6 +48,8 @@ internal record ReleaseConfig

public required bool Internal { get; init; }

[MemberNotNullWhen(false, nameof(Asp))]
[MemberNotNullWhen(false, nameof(AspBuild))]
public required bool SdkOnly { get; init; }

private static readonly JsonSerializerOptions s_jsonOptions = new()
Expand Down