Merged
Conversation
ghost
added
the
area-Meta
Contributor
|
@gewarren - This PR edits one or more files whose 'source of truth' for documentation is not in this repo. Please make documentation updates in the /// comments in the dotnet/runtime repo (or dotnet/extensions repo) instead. |
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Feb 28, 2025
gewarren
requested review from
a team,
333fred,
David-Engel,
cheenamalhotra and
cston
as code owners
|
Learn Build status updates of commit 3b577a2:
|
carlossanlop
approved these changes
Feb 28, 2025
Contributor
carlossanlop
left a comment
carlossanlop
left a comment
There was a problem hiding this comment.
There are refs not getting resolved, and I left two suggestions.
I dared viewing by commit as you suggested, and I lost.
| </summary> | ||
| <returns> | ||
| An <see cref="T:Microsoft.Extensions.Primitives.IChangeToken" /> that is notified when a file matching <paramref name="filter" /> is added, | ||
| modified, or deleted. Returns a <see cref="T:Microsoft.Extensions.FileProviders.NullChangeToken" /> if <paramref name="filter" /> has invalid filter | ||
| characters or if <paramref name="filter" /> is an absolute path or outside the root directory specified in the | ||
| constructor <see cref="M:Microsoft.Extensions.FileProviders.PhysicalFileProvider.#ctor(System.String)" />. | ||
| constructor <seealso cref="M:Microsoft.Extensions.FileProviders.PhysicalFileProvider.#ctor(System.String)" />. |
Contributor
There was a problem hiding this comment.
Did these seealso come from source? If yes, shouldn't they be failing in source too?
Suggested change
| constructor <seealso cref="M:Microsoft.Extensions.FileProviders.PhysicalFileProvider.#ctor(System.String)" />. | |
| constructor <see cref="M:Microsoft.Extensions.FileProviders.PhysicalFileProvider.#ctor(System.String)" />. |
Contributor
Author
There was a problem hiding this comment.
Yes, I've fixed them in source here: https://github.com/dotnet/runtime/pull/113027/files. Not sure why the compiler doesn't flag it.
adegeo
approved these changes
Mar 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View by commit (if you dare).
Fixes #10914.