-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Port Microsoft.Extensions.Primitives new docs #10169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Microsoft.Extensions.Primitives new docs #10169
Conversation
This reverts commit f2998eb.
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
1 similar comment
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Learn Build status updates of commit 14e142b: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xrefs are weird though.
Tagging subscribers to this area: @dotnet/area-extensions-primitives |
Should I be fixing that up manually? It looks OK in the source .cs |
I'm not sure why the porting tool does this sometimes. It would be great if you can fix them manually. |
@directhex you're seeing xrefs inside markdown remarks. Those are valid. No need to convert them. If you were seeing xrefs outside of markdown, the build would've failed. But that's not the case. Ideally, area owners should be adding remarks as plain xml elements to their triple slash comments, but if they were added as markdown to triple slash, the tool transfers them in that format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left the suggested changes for the weird xrefs.
I wonder why the buld didn't fail. I guess they were formatted as valid xml, even though the elements themselves are not the correct ones.
Co-authored-by: Carlos Sánchez López <[email protected]>
Co-authored-by: Carlos Sánchez López <[email protected]>
Co-authored-by: Carlos Sánchez López <[email protected]>
Co-authored-by: Carlos Sánchez López <[email protected]>
Learn Build status updates of commit 006d159: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit f70db18: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
@dotnet/area-extensions-primitives @carlossanlop @gewarren PTAL
There's some line-ending mess in this file, I think the committed file is a mix of LF and CRLF so my touching it screws up as git normalizes the whole file one way or the other