Skip to content

Conversation

directhex
Copy link
Contributor

@dotnet/area-extensions-primitives @carlossanlop @gewarren PTAL

There's some line-ending mess in this file, I think the committed file is a mix of LF and CRLF so my touching it screws up as git normalizes the whole file one way or the other

@directhex directhex requested a review from a team as a code owner July 26, 2024 21:06
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 26, 2024
@ghost
Copy link

ghost commented Jul 26, 2024

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

1 similar comment
@ghost
Copy link

ghost commented Jul 26, 2024

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link

Learn Build status updates of commit 14e142b:

✅ Validation status: passed

File Status Preview URL Details
xml/Microsoft.Extensions.Primitives/StringValues.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xrefs are weird though.

@tarekgh tarekgh added area-Extensions-Primitives and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 28, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-extensions-primitives

@directhex
Copy link
Contributor Author

xrefs are weird though.

Should I be fixing that up manually? It looks OK in the source .cs

@gewarren
Copy link
Contributor

xrefs are weird though.

Should I be fixing that up manually? It looks OK in the source .cs

I'm not sure why the porting tool does this sometimes. It would be great if you can fix them manually.

@carlossanlop
Copy link
Contributor

Should I be fixing that up manually? It looks OK in the source .cs

@directhex you're seeing xrefs inside markdown remarks. Those are valid. No need to convert them.

If you were seeing xrefs outside of markdown, the build would've failed. But that's not the case.

Ideally, area owners should be adding remarks as plain xml elements to their triple slash comments, but if they were added as markdown to triple slash, the tool transfers them in that format.

Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left the suggested changes for the weird xrefs.
I wonder why the buld didn't fail. I guess they were formatted as valid xml, even though the elements themselves are not the correct ones.

Copy link

Learn Build status updates of commit 006d159:

✅ Validation status: passed

File Status Preview URL Details
xml/Microsoft.Extensions.Primitives/StringValues.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit f70db18:

✅ Validation status: passed

File Status Preview URL Details
xml/Microsoft.Extensions.Primitives/StringValues.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@carlossanlop carlossanlop merged commit bc2b8ea into dotnet:main Jul 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants