Skip to content

Conversation

KubaZ2
Copy link
Contributor

@KubaZ2 KubaZ2 commented Sep 10, 2024

Fixes #9877

Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @KubaZ2

@yufeih yufeih merged commit 650ff51 into dotnet:main Sep 14, 2024
7 checks passed
@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Sep 14, 2024
@filzrev
Copy link
Contributor

filzrev commented Sep 14, 2024

This PR introduce some behavior changes on existing docfx site.

Currently if there is no matching navigation element exists. first element is selected by default.
But after this PR merged. no element is activated.

Example URLs

When opening above URLs.
Docs navigation is activated before PR is merged.
But after this PR is merged. no navigation element is activated.

I'm not particularly concerned about the differences in behavior.
But it should be documented as BREAKING CHANGES on release note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Modern template always sets the first navbar element as active
3 participants