[10.0-rc1] Mop up changes that missed the RC1 snap #63318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions behavior (#63231) * Add support for type-level validation attributes, update validation ordering * Code review fix, test fix * Fix trimming annotation * Fix trimming annotation * Separate caches for property and type attributes * Fix typo Co-authored-by: Brennan <[email protected]> * Fix typo Co-authored-by: Brennan <[email protected]> * Fix and simplify the emitted code * Update src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/ValidationsGeneratorTestBase.cs --------- Co-authored-by: Brennan <[email protected]> Co-authored-by: Safia Abdalla <[email protected]>
wtgodbe
added
the
tell-mode
wtgodbe
requested review from
BrennanConroy,
halter73,
JamesNK,
a team and
captainsafia
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates "mop up" changes that missed the RC1 snap for .NET 10.0. The changes span multiple areas including validation infrastructure improvements, cookie authentication metadata updates, SignalR client optimizations, and Kestrel HTTP/3 stream handling enhancements.
Key Changes:
- Validation system enhancements: Added support for type-level validation attributes and improved validation ordering (property → type → IValidatableObject)
- Cookie authentication metadata refactoring: Renamed
IApiEndpointMetadatatoIDisableCookieRedirectMetadatawith more granular control - SignalR client optimization: Improved keep-alive ping handling to avoid dependency on JavaScript timer throttling
Reviewed Changes
Copilot reviewed 155 out of 156 changed files in this pull request and generated 3 comments.
Show a summary per file
:
| File | Description |
|---|---|
| src/Validation/ | Added type-level validation support, test consolidation, and validation ordering improvements |
| src/Security/Authentication/ | Renamed cookie redirect metadata interfaces and added granular control mechanisms |
| src/SignalR/clients/ts/ | Optimized keep-alive ping timing to handle overdue pings immediately |
| src/Servers/Kestrel/Core/ | Enhanced HTTP/3 stream reuse logic to prevent reusing aborted streams |
| src/Http/Http.Results/ | Updated to use renamed cookie redirect metadata interfaces |
| src/Mvc/ | Updated API controller attribute and added .slnx solution file support tests |
src/Validation/test/Microsoft.Extensions.Validation.Tests/ValidatableTypeInfoTests.cs
Show resolved
Hide resolved
src/Validation/test/Microsoft.Extensions.Validation.Tests/ValidatableTypeInfoTests.cs
Show resolved
Hide resolved
src/Validation/test/Microsoft.Extensions.Validation.Tests/ValidatableTypeInfoTests.cs
Show resolved
Hide resolved
lewing
approved these changes
Aug 18, 2025
captainsafia
approved these changes
Aug 18, 2025
BrennanConroy
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Folks didn't know we were snapping early this time - merging the last set of Friday changes that missed the snap. Marking as tell-mode as this has already been discussed offline