-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[release/9.0] Apply schema transformer to AdditionalProperties #59730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Approved via email. |
captainsafia
approved these changes
Jan 10, 2025
This was referenced Feb 12, 2025
1 task
This was referenced Jul 22, 2025
Closed
Closed
Closed
This was referenced Aug 18, 2025
Closed
Open
This was referenced Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-minimal
Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc
area-mvc
Includes: MVC, Actions and Controllers, Localization, CORS, most templates
feature-openapi
Servicing-approved
Shiproom has approved the issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #59699 to release/9.0
/cc @captainsafia @JTeeuwissen
Description
This pull request invokes the schema transformer to the AdditionalProperties field within the JSON schema.
Fixes #59616
Customer Impact
This change is necessary to ensure the schema transformer correctly applies to AdditionalProperties, a sub-field within the JSON schema.
While there are workarounds for this issue, the workarounds require the user to implement an extensive amount of custom code in order to properly recurse into an AdditionalProperties subschemas for a given type.
Regression?
Risk
Low risk because:
Verification
Packaging changes reviewed?