Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 12, 2024

Backport of #58895 to release/9.0

/cc @BrennanConroy

Fix SignalR Java POM to include description

Description

When updating our macOS CI machines, due to the ones we were using about to be removed, we had to update our gradle reference (what builds java). This update contained many breaking changes which required a lot of work to update how we bundle our packages. Unfortunately, we missed some metadata during the update which prevents the packages from being published.

Customer Impact

Version 9.0 of our Java packages are not published.

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Changing metadata not code, locally validated that the file contains the missing metadata.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@ghost ghost added the area-signalr Includes: SignalR clients and servers label Nov 12, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0.x milestone Nov 12, 2024
@BrennanConroy BrennanConroy added ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it. Servicing-approved Shiproom has approved the issue and removed ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it. labels Nov 13, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Nov 21, 2024
@wtgodbe
Copy link
Member

wtgodbe commented Nov 27, 2024

@BrennanConroy does this need fixing up?

@wtgodbe
Copy link
Member

wtgodbe commented Nov 27, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@wtgodbe wtgodbe merged commit 0eb3437 into release/9.0 Nov 27, 2024
25 checks passed
@wtgodbe wtgodbe deleted the backport/pr-58895-to-release/9.0 branch November 27, 2024 22:46
@dotnet-policy-service dotnet-policy-service bot modified the milestones: 9.0.x, 9.0.1 Nov 27, 2024
This was referenced Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-signalr Includes: SignalR clients and servers pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants