-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[release/9.0] Add explicit conversion for value-type returning handlers with filters #57967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr-TRADERS
reviewed
Sep 27, 2024
src/Http/Http.Extensions/test/RequestDelegateFactoryTests.EndpointFilters.cs
Show resolved
Hide resolved
Approved via email. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@BrennanConroy @amcasey Can I get a review here? This is the same as the changeset in the other branches. |
BrennanConroy
approved these changes
Oct 1, 2024
This was referenced Jul 22, 2025
Closed
This was referenced Aug 11, 2025
This was referenced Aug 18, 2025
Open
Open
This was referenced Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-minimal
Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc
feature-rdf
Servicing-approved
Shiproom has approved the issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #52128.
This PR fixes a bug with the handling of value type-returning handlers that are used in conjunction with endpoint filters. Such as:
This currently throws:
Because the return type requires an explicit conversion before being wrapped as a
ValueTask<object>
to confirm with the EndpointFilterDelegate's signature.Customer Impact
Without this bug fix, user applications that contain minimal API endpoints that return value types and use endpoint filters will fail to launch. Viable workarounds exist (for example, wrapping the value return in a
Results.Ok
), but they are difficult for the typical user to discover.Regression?
Risk
Scope of impact is limited to minimal APIs + endpoint filters + compile-time code generation.
Verification
Packaging changes reviewed?