[release/9.3] Skip role assignment handling for emulators (#9705) #9716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `BuildRoleAssignmentAnnotations` to skip processing for container emulators. - Added a new test `DoesNotApplyRoleAssignmentsInRunModeForEmulators` to verify that role assignments are not applied to emulator resources.
There was a problem hiding this comment.
Pull Request Overview
This PR skips role assignment processing for container emulator resources to prevent requiring Azure subscription details in local emulator scenarios.
- Update BuildRoleAssignmentAnnotations to bypass container resources.
- Add DoesNotApplyRoleAssignmentsInRunModeForEmulators test to verify the skipping behavior in run mode.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/Aspire.Hosting.Azure.Tests/AzureResourcePreparerTests.cs | Adds a test case to confirm role assignments are not applied for emulators. |
| src/Aspire.Hosting.Azure/AzureResourcePreparer.cs | Introduces a check to skip role assignment processing for container emulator resources. |
Comments suppressed due to low confidence (1)
src/Aspire.Hosting.Azure/AzureResourcePreparer.cs:146
- [nitpick] The method name IsContainer may be ambiguous if it is intended specifically to identify emulator resources; consider clarifying its usage through renaming or additional documentation.
if (azureReference.IsContainer())
github-actions
bot
added
the
area-app-model
sebastienros
approved these changes
Jun 5, 2025
danmoseley
added
Servicing-approved
danmoseley
approved these changes
Jun 5, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BuildRoleAssignmentAnnotationsto skip processing for container emulators.DoesNotApplyRoleAssignmentsInRunModeForEmulatorsto verify that role assignments are not applied to emulator resources.Fixes #9422
Customer Impact
Users are unable to F5 their application when they don't have Azure subscription information added, even though they are using the local emulator. We shouldn't require Azure subscription information when using emulators.
Testing
Added new test. Plus manual.
Risk
Low
Regression?
Yes