Skip to content

Conversation

radical
Copy link
Member

@radical radical commented May 15, 2025

The earlier revert was incorrect. That wasn't commit responsible for breaking the build. It was:

commit 6ca2de945a44868673e12fa43e2a76055c34bf4a
Author: Ankit Jain <[email protected]>
Date:   Wed May 14 11:39:18 2025 -0400

    [CI] Add PR validation on macOS (#9287)

This reverts commit 3850afa.

…otnet#9336)"

The earlier revert was incorrect. That wasn't commit responsible for
breaking the build. It was:
```
commit 6ca2de9
Author: Ankit Jain <[email protected]>
Date:   Wed May 14 11:39:18 2025 -0400

    [CI] Add PR validation on macOS (dotnet#9287)
```

This reverts commit 3850afa.
@Copilot Copilot AI review requested due to automatic review settings May 15, 2025 19:02
@github-actions github-actions bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label May 15, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR re-reverts a previous revert to reapply the xUnit.v3 updates required for MTP tests.

  • Reapplies changes by reverting commit 3850afa.
  • Updates dependency versions in eng/Versions.props.
  • Adjusts VS Code settings in .vscode/settings.json to enable testing using the Testing Platform Protocol.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
eng/Versions.props Bumps xUnit V3, XUnitAnalyzers, and XunitRunnerVisualStudio versions accordingly.
.vscode/settings.json Enables the Testing Platform Protocol by changing dotnet.testWindow.useTestingPlatformProtocol from false to true.

@radical radical requested review from danmoseley and joperezr May 15, 2025 19:18
@radical radical added area-engineering-systems infrastructure helix infra engineering repo stuff testing ☑️ and removed area-codeflow for labeling automated codeflow. intentionally a different color! labels May 15, 2025
@danmoseley danmoseley merged commit c8beecd into dotnet:main May 15, 2025
255 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-engineering-systems infrastructure helix infra engineering repo stuff testing ☑️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants