[release/9.2] Fix AE in ExecutableResource #8864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
danmoseley
added
the
area-app-model
dotnet-policy-service
bot
added
Re-opened Github-Action PR
and removed
Closed Github-Action PR
labels
davidfowl
approved these changes
Apr 18, 2025
|
@joperezr could you please be 2nd signoff so we can merge |
joperezr
approved these changes
Apr 18, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #8797 to release/9.2
/cc @danmoseley
Customer Impact
In 9.1 customers could do
builder.AddExecutable("name", "exec", "");ie.,, pass an empty string for the working directory so it's found on $PATH. We accidentally broke this in 9.2.Testing
Unit tests.
Risk
Very low as it's allowing a value previously allowed.
Regression?
Yes