Skip to content

Follow up from azd naming change #8631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

Follow up from azd naming change #8631

merged 1 commit into from
Apr 8, 2025

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Apr 8, 2025 •
edited
Loading

Description

Remove dots and dashes from the volume name to align with azd naming

This change was included in [release/9.2] AddAzureContainerAppEnvironment should use the environment name as a prefix (dotnet/aspire#8607). Forward porting it back to main and adding a test.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
  • Did you add public API?
    • No
  • Does the change make any security assumptions or guarantees?
    • No
  • Does the change require an update in our Aspire docs?
    • No

@eerhardt eerhardt requested review from davidfowl and Copilot April 8, 2025 15:02
@github-actions github-actions bot added the area-integrations Issues pertaining to Aspire Integrations packages label Apr 8, 2025
Copilot
Copilot AI reviewed Apr 8, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@eerhardt eerhardt merged commit c29004a into dotnet:main Apr 8, 2025
176 checks passed
@eerhardt eerhardt deleted the FollowupNamingChange branch April 8, 2025 15:22
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@davidfowl davidfowl davidfowl approved these changes

Assignees
No one assigned
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eerhardt @davidfowl