Fix a regression in endpoint resolution in environment variables #8609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Endpoints wrapped in connection strings were throwing during the preproces pass of the evalution. Avoid throwing during that pass - Added tests for this scenario Fixes #8596
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/Aspire.Hosting/ApplicationModel/ExpressionResolver.cs:163
- Consider adding tests for scenarios when Preprocess is true to ensure that missing connection strings do not trigger an exception during pre-processing.
if (!Preprocess && string.IsNullOrEmpty(value.Value) && !cs.Optional)
github-actions
bot
added
the
area-app-model
|
/backport to release/9.2 |
|
Started backporting to release/9.2: https://github.com/dotnet/aspire/actions/runs/14323470219 |
mitchdenny
approved these changes
Apr 8, 2025
|
hey @afscrome thanks for finding this and other last minute issues. really helps. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8596
Checklist